New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `@dataclass(frozen=True)` fail on name shadowing #12088

Closed

sobolevn wants to merge 2 commits into python:master from sobolevn:issue-12084

Member

sobolevn commented Jan 28, 2022 •

edited

Loading

There are two things that I've done:

Now we clear attributes from dataclass that are shadowed by methods. It is helpful, so __call__ won't be considered a dataclass attribute, the same as runtime does
assert -> if change to be safe and not fail. Why I want to be extra safe? Because we can shadow attrs with class, import, import from, @property possibly something else. I don't want to dive deep into supporting everything here, just not crashing is good enough

Feedback is welcome!

Closes #12084

sobolevn added 2 commits

January 28, 2022 10:30


          Fix @dataclass(frozen=True) fail on name shadowing

15ed0c1


          Update dataclasses.py

c0ecf9b

sobolevn mentioned this pull request

Adds __hash__ method to @dataclasses.dataclass, refs #11463 #11496

Closed

This pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet