Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update NCCL to 2.19.3 #1668

Closed
wants to merge 2 commits into from
Closed

update NCCL to 2.19.3 #1668

wants to merge 2 commits into from

Conversation

ptrblck
Copy link
Contributor

@ptrblck ptrblck commented Jan 8, 2024

malfet
malfet approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really weird, I though I've made this change in the past, but guess I did not :(

P.S. It uses nccl for cuda-12.0 vs 12.1, is this OK?

@atalman
Copy link
Contributor

atalman commented Jan 8, 2024

@malfet Yes looks like we would need to use 12.0 cuda nccl : NVIDIA/nccl#1093

atalman
atalman reviewed Jan 8, 2024
View reviewed changes
@bryantbiggs
Copy link
Contributor

superseded by #1724

@ptrblck
Copy link
Contributor Author

ptrblck commented Mar 13, 2024

Closing

@ptrblck ptrblck closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@malfet malfet malfet approved these changes

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly pip wheel+cu121 reports NCCL==2.18.1, but installs nvidia-nccl-cu12==2.19.3
6 participants
@ptrblck @atalman @bryantbiggs @huydhn @malfet @facebook-github-bot