fix(publish): Can only publish / unpublish a head reference

qri-io · Nov 4, 2019 · f834621 · f834621
1 parent 1348506
commit f834621
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/cmd/publish.go b/cmd/publish.go
@@ -25,7 +25,7 @@ to a published dataset will be immediately visible to connected peers.
   $ qri publish me/dataset me/other_dataset
 
   # unpublish a dataset
-  $ qri publish -unpublish me/dataset
+  $ qri publish --unpublish me/dataset
 
   # publish a few dataset on p2p only
   $ qri publish --no-registry me/dataset_2`,

diff --git a/lib/remote.go b/lib/remote.go
@@ -2,6 +2,7 @@ package lib
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/qri-io/qri/base"
 	"github.com/qri-io/qri/remote"
@@ -82,6 +83,9 @@ func (r *RemoteMethods) Publish(p *PublicationParams, res *repo.DatasetRef) erro
 	if err != nil {
 		return err
 	}
+	if ref.Path != "" {
+		return fmt.Errorf("can only publish entire dataset, cannot use version %s", ref.Path)
+	}
 	if err = repo.CanonicalizeDatasetRef(r.inst.Repo(), &ref); err != nil {
 		return err
 	}
@@ -121,6 +125,11 @@ func (r *RemoteMethods) Unpublish(p *PublicationParams, res *repo.DatasetRef) er
 	if err != nil {
 		return err
 	}
+
+	if ref.Path != "" {
+		return fmt.Errorf("can only unpublish entire dataset, cannot use version %s", ref.Path)
+	}
+
 	if err = repo.CanonicalizeDatasetRef(r.inst.Repo(), &ref); err != nil {
 		return err
 	}