Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter selects wrong items #145

Closed
Cazimodo opened this issue Nov 15, 2017 · 4 comments
Closed

Filter selects wrong items #145

Cazimodo opened this issue Nov 15, 2017 · 4 comments

Comments

@Cazimodo
Copy link

qgrid filter issue

To reproduce:

  1. Go to demo binder as per your github readme: https://beta.mybinder.org/v2/gh/quantopian/qgrid-notebooks/master?filepath=index.ipynb
  2. Scroll to example 4
  3. Execute the cell which displays the qgrid country GDP
  4. Click Filter icon for Country column
  5. Type in 'South' to filter the list down to 'South Africa'
  6. Click tick box next to South Africa
  7. Notice that the qgrid then displays gdp for Afghanistan rather than South Africa. Now while our economy is being ransacked by the powers that be I'd hope we're doing a bit better than Afghanistan :)
  8. Just scrolling down to South Africa and selecting it works fine
@TimShawver
Copy link
Contributor

TimShawver commented Nov 18, 2017

Thanks for the report...this sounds like the same issue as #135. I'm working on a fix today and I expect to release a new beta with that fix by EOD tomorrow (Sunday).

@Cazimodo
Copy link
Author

Hmmm, I suspect you meant this is a duplicate of another issue. this IS issue #145. Closest one I could find with my limited knowledge of qgrid is #137

@TimShawver
Copy link
Contributor

Sorry, yea I copied the wrong URL, I meant #135.

TimShawver pushed a commit that referenced this issue Nov 18, 2017
… applied resulted in the wrong rows being shown (#135, #144, #145).
@TimShawver
Copy link
Contributor

The fix has been merged and released in beta 8 (which you can get by uninstalling and reinstalling qgrid). I'm going to close this for now but feel free to reopen it if the new version doesn't work for you. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants