Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update grid.py for changes in pandas 1.0.1 #290

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

richlysakowski
Copy link
Contributor

Pandas 1.0.1 had a breaking change for qgrid because core.index was deprecated. This fixes it. For more information see: #287

Pandas 1.0.1 had a breaking change for qgrid because core.index was deprecated.   This fixes it.  For more information see:  quantopian#287
Copy link
Contributor

@ssanderson ssanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@ssanderson ssanderson merged commit 686d33f into quantopian:master Feb 7, 2020
@richlysakowski richlysakowski deleted the patch-1 branch February 7, 2020 07:09
@ankostis
Copy link

Thank you.
I would just change the titleof this PR to "Update qgrid.py to pandas-1.0.0"

@gerrymanoim gerrymanoim changed the title update grid.py update grid.py to pandas 1.0.1 Feb 11, 2020
@gerrymanoim gerrymanoim changed the title update grid.py to pandas 1.0.1 update grid.py for changes in pandas 1.0.1 Feb 11, 2020
@ankostis
Copy link

ankostis commented Feb 12, 2020

(I know it's not my business :-)

Is there a reason not to use isinstance(df.index, pd.MultiIndex) (instead of type(df.index) is pd.MultiIndex)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants