Downgrade Opentracing contrib JDBC to a version that didn't use a proxy #18128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
the
area/dependencies
loicmathieu
added
triage/backport?
and removed
area/dependencies
kenfinnigan
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
I have no issue with this as long as CI is good.
@luneo7 any concerns with this?
|
Well @kenfinnigan you know CI is sometimes happy, sometines not ;) |
luneo7
approved these changes
Jun 24, 2021
|
I also have no issues with it =] |
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building c93e8f2
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 16 #📦 extensions/vertx-http/deployment✖ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @kenfinnigan
@gsmet as it's too late for Quarkus 2.0, I'll add a note about it in the migration guide, people using the Opentracing JDBC driver would need to manually downgrade the version inside there pom.xml. Maybe it's also worth a note in the annoucement blog post.
I'll try to add an integration test for it tomorrow and open an issue upstream as discussed in #18033