-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: extension readme #394
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #394 +/- ##
===========================================
+ Coverage 54.34% 68.41% +14.06%
===========================================
Files 49 70 +21
Lines 5025 11838 +6813
Branches 5025 11838 +6813
===========================================
+ Hits 2731 8099 +5368
- Misses 2245 3482 +1237
- Partials 49 257 +208 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have basic examples (similar to the one in mock test). In overall, I'm happy with the doc, very well-written!
You mean adding examples to the readme? |
Looking at the existing code in the testnet runtime, there are a lot of noises aside from the direct configuration of the module. Something like the code snippet below could be useful for someone that interested to use this in their code. struct ExampleFunction;
...
pub(crate) type Functions = (
ExampleFunction<WithFuncId<ExampleFuncId>, Runtime>,
);
#[derive(Default)]
pub struct Config;
impl super::Config for Config {
type Functions = Functions;
const LOG_TARGET: &'static str = "pop-chain-extension";
} |
No description provided.