spike foreign fungibles #475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daanvdplas
commented
Feb 18, 2025
| /// - `to` - The recipient account. | ||
| /// - `value` - The number of tokens to transfer. | ||
| #[inline] | ||
| pub fn transfer(token: TokenId, to: AccountId, value: Balance) -> Result<()> { |
There was a problem hiding this comment.
Only added transfer and balance_of to make the integrations tests work. This will be a duplication of the functions in the fungibles module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Close annotations in the
Files changedsection by clicking the right corner 3 dots when reviewing because I only pushed the relevant bits)Shows how we can implement the foreign fungibles functionality by having a separate instance of the fungibles pallet. This adds duplicate code to the pop api crate but reduces the added complexity in the fungibles pallet.
See latest commit to get a feel for the contract.
fungibles contract: 14.2K
foreign fungibles contract: 22.8K
Integrations tests for transfer and balance_of are working.