-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chain-spec): add mainnet spec artifacts #476
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #476 +/- ##
=======================================
Coverage 76.89% 76.89%
=======================================
Files 89 89
Lines 18184 18184
Branches 18184 18184
=======================================
Hits 13983 13983
Misses 3935 3935
Partials 266 266 |
How can we review this best? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the steps you provided above, also created the genesis state and wasm from the chain spec with pop cil
.
Everything matched, nice job.
Can we rename 3395-mainnet-head-state
to 3395-mainnet-genesis-state
or pop-genesis-state
.
It is a little bit inconsistent with the file names in testnet, also the mainnet part in the files names seems unnecessary because it is in the mainnet folder.
Perhaps:
pop-wasm
pop-polkadot.plain.json
pop-polkadot.raw.json
pop-genesis-state
Yeah, that makes sense! |
This PR adds to the repo the genesis spec, code, state and hash for pop mainnet.
Providing an easier way to access this should benefit us and external contributors.
A new directory is created:
mainnet
to contains these in the previously existing chain-specs folder.The previously existing specs used for registering the testnet to Paseo are moved to a new directory:
testnet
.How can this be reviewed ?
Compare the artifacts in submitted in this PR with the ones submitted on-chain. These can be retrieved by querying:
paras.heads
. Should contain a value matching the genesis state as the mainnet chain hasn't advanced yet.paras.currentCodeHash
returns the hash of the code. This hash can be use to query for the code itself on keyparas.codeByHash
, the result should match the genesis wasm as the mainnet chain hasn't received any code upgrade yet.pop-node --chain <mainnet-spec> --tmp
)[sc-2771]