Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add a method to check if row group stats are available #17864

Open
mhaseeb123 opened this issue Jan 29, 2025 · 0 comments
Open

[FEA] Add a method to check if row group stats are available #17864

mhaseeb123 opened this issue Jan 29, 2025 · 0 comments
Labels
0 - Backlog In queue waiting for assignment good first issue Good for newcomers

Comments

@mhaseeb123
Copy link
Member

mhaseeb123 commented Jan 29, 2025

Is your feature request related to a problem? Please describe.
Currently, there isn't a method in predicate_pushdown.cpp (filter_row_groups) to check if row group stats aren't available. Hence, we can't ever set num_surviving_row_groups.after_stats_filter to std::nullopt if stats are unavailable.

Describe the solution you'd like
We should figure out a relatively cheaper way to distinguish if row group stats aren't available if possible.

Describe alternatives you've considered
We currently build the entire statsAST table in predicate_pushdown and try to filter row groups with it. In case no row groups are filtered, we can't distinguish if this was due to ineffective filter or missing stats.

Additional context
Originally posted by @mhaseeb123 in #17594 (comment)

@mhaseeb123 mhaseeb123 changed the title Add a method to check if row group stats are available [FEA] Add a method to check if row group stats are available Jan 29, 2025
@mhaseeb123 mhaseeb123 added the 0 - Backlog In queue waiting for assignment label Jan 29, 2025
@mhaseeb123 mhaseeb123 added the good first issue Good for newcomers label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

1 participant