Update build system and docs to state cuda 11 required #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkraus14
reviewed
Mar 31, 2021
robertmaynard
force-pushed
the
update_build_system_and_docs_to_state_cuda_11_required
branch
from
57f315f to
e60181e
Compare
|
rerun tests |
|
It is expected that all the builds won't pass since we still have CUDA 10.1 and 10.2 testers |
|
We still haven't heard from 2 of our stakeholders on #736... |
harrism
added
3 - Ready for review
|
rerun tests |
Starting with rmm-0.20 the minimum allowed C++ and CUDA language level is C++17.
robertmaynard
force-pushed
the
update_build_system_and_docs_to_state_cuda_11_required
branch
from
e60181e to
1bbea24
Compare
We have now. Good to go. |
harrism
approved these changes
Apr 5, 2021
kkraus14
approved these changes
Apr 5, 2021
|
rerun tests |
kkraus14
added
doc
|
@gpucibot merge |
robertmaynard
deleted the
update_build_system_and_docs_to_state_cuda_11_required
branch
4 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 1, 2021
#741 moved the code base over to C++17, and as discussed in #736 moving Cython compilation over is fine as well but has not been done yet. There's some use of structured bindings in there now (in `cuda_async_memory_resource.hpp`) so the Cython compilation should be switched over as well. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - https://github.com/jakirkham - Mark Harris (https://github.com/harrism) URL: #787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #736
rmm-0.20 increase the minimum requirements in the following way:
-std=c++17This updates the build-system and the README with these new requirements