Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: autoAlign pos #405

Merged
merged 3 commits into from
Jun 29, 2023
Merged

feat: autoAlign pos #405

merged 3 commits into from
Jun 29, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 28, 2023

会根据 align 位置自动选择是通过 left | right or top | bottom 进行定位,以优化从上方打开时高度变化引起的跳动问题。

防止 breaking change,需要配置开启。

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #405 (b7bb86b) into master (cf29179) will decrease coverage by 0.14%.
The diff coverage is 93.75%.

❗ Current head b7bb86b differs from pull request most recent head 448b337. Consider uploading reports for the commit 448b337 to get more accurate results

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   96.68%   96.54%   -0.14%     
==========================================
  Files          13       13              
  Lines         724      753      +29     
  Branches      221      216       -5     
==========================================
+ Hits          700      727      +27     
- Misses         24       26       +2     
Impacted Files Coverage Δ
src/index.tsx 94.91% <ø> (ø)
src/Popup/index.tsx 90.00% <89.47%> (-0.91%) ⬇️
src/hooks/useAlign.ts 96.53% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zombieJ zombieJ marked this pull request as ready for review June 29, 2023 02:02
@zombieJ zombieJ merged commit 2af861f into master Jun 29, 2023
@zombieJ zombieJ deleted the auto-align branch June 29, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants