Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected document dimensions in paginated mode #158

Open
qnga opened this issue Nov 22, 2024 · 1 comment
Open

Unexpected document dimensions in paginated mode #158

qnga opened this issue Nov 22, 2024 · 1 comment

Comments

@qnga
Copy link
Member

qnga commented Nov 22, 2024

Document dimensions in paginated mode are weird. Height is huge because of the blank space left below content.

Steps to reproduce the issue/enhancement:

  1. Version in the Kotlin toolkit, in an Android WebView
  2. No custom properties injected

What is the expected behaviour?
No blank space below content, a height value of the screen height.

What is the current behaviour?
Capture d’écran du 2024-11-22 09-21-10

@JayPanoz
Copy link
Collaborator

Alright, so after checking old screenshots from years ago, the good news is that it’s always been like that. And it doesn’t impact document.scrollableElement negatively.

The bad news is that I can’t explain why we didn’t add an height to body so that the number is the same as :root/html. Could be that it messed up fragmentation, with lines being clipped at the top or the bottom of columns, but I couldn’t find any confirmation in issues, documentation, nor comments. Or maybe it messed up columns → scroll update, I can’t tell, that was not documented, unfortunately.

This would be a simple fix then (setting a max-height dimension to body in pagination, and resetting it in scroll), but I can’t tell the impact at the moment. This would have to be stress-tested first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants