-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this package still actively maintained? #1870
Comments
I don't enjoy spamming people, but everyone who relies on @banker / @vmihailenco / @yossigo / @trevor211 / @itamarhaber / @oranagra / @yangbodong22011 / @ShooterIT / @enjoy-binbin / @hpatro / @slorello89 / @hwware |
a lot of unaddressed issues were closed by stalebot simply because no one responded (hella stupid right). there's a lot more than the current open ones. |
i am not the person in charge. this package will still be maintained, it just need take some times when the maintainer have time. recently, there have been a lot of things about redis changing the license, i guess they don’t have much time right now. i took a quick look, and there did not seem to be any serious problems here. this project is now mature and stable and the maintainers usually do not have a lot of free time to check with every PR. |
Hi @qsymmachus As @enjoy-binbin mentioned above, ioredis is a mature project with no critical issues. To make the project even more stable, we are working on a maintenance release to make it more reliable when you connect to Redis Cluster. It is worth mentioning that the most advanced Redis client for Node.js is Node-Redis. In Node-Redis V5, we will release support for major features like RESP3 support, Client-Side caching, and many more. That's why, for new projects, we recommend using Node-Redis instead. In the future, we will consider adding a smooth transition path to Node-Redis with ioredis API-compatible wrapper. This ensures that switching between client libraries is as easy as swapping dependencies and imports. If you are missing any notable feature in Node-Redis, please share your thoughts here. After the Node-Redis v5 release, we want to start a community discussion to collect all missing and long-awaited features and build a public roadmap for Node-Redis V6 to address those requests. |
@uglide Isn't ioredis still both faster (see https://ably.com/blog/migrating-from-node-redis-to-ioredis) and also supporting more use-cases? E. g. node-redis still doesn't support |
@kibertoad Thanks for the question! Support for command timeouts has been on our radar for some time. That's why we want to start a community discussion to collect all the missing features in Node-Redis after the V5 release. |
@uglide Would you say that this is an intended behaviour and generally is fine? |
@kibertoad As I pointed out above, the article refers to the state where Node-Redis was three years ago; since then, It has been rewritten. You can see it if you follow the link from the article and try to switch to the master branch - the file doesn't exist anymore. The new implementation is much more efficient, and you can check the code yourself. |
OK but maybe someone could write an article on how to migrate? I am unfamiliar with node-redis. I do know Elastic Cache is supporting a ton more advanced features and would like to improve performance and support clustering more. |
I've proposed updating the README here to indicate that new projects should use Node-Redis. We recently started using ioredis and discovered this issue a few weeks into implementation. Teams in our situation would benefit from knowing about this as early as possible. |
Also, In my personal opinion, ioredis is the better engineered module. |
@silverwind Node-Redis V5 has Sentinel support redis/node-redis#2664 |
If this is no longer supported it should be made clear. What's going on? Any (former) maintainers willing to comment? Thanks. @bobymicroby @leibale @uglide any thoughts? You all did commits recently. Is it a licensing dispute or something? |
Hello, and thanks for your feedback. There is no licensing dispute for this or other open-source client libraries maintained by Redis. As discussed in this thread, ioredis maintenance is done on a best-effort basis for critical issues, but in the medium term, we aim to offer a migration path to node-redis, the open-source (MIT license) Redis JavaScript library redesigned from the ground up to overcome some design limitations in ioredis. We are working to provide a frictionless migration experience to node-redis. In addition, contributions to ioredis will be evaluated, reviewed, and merged when they benefit the project. |
Hi @kristianjaeger, as @mortensi explained, ioredis is a stable project and maintenance is provided on a best-effort basis for relevant issues (contributions to ioredis will still be evaluated, reviewed, and merged when they benefit the project). For new projects, we recommend using the node-redis client library. We have updated the README to better reflect this recommendation. Thanks for your feedback! |
Thanks so much, @mortensi and @bobymicroby ! I really appreciate your responses and clarification. Cheers. |
Please verify and look at AWS ValKey features and confirm it is working - node_redis recently releases fixes for this product. |
Many people and organizations rely on this package, but the last commit was made in September 2023. The list of open PRs is also growing, with most of them left with no review from a collaborator, let alone merged.
Now that @luin is no longer the primary maintainer of
ioredis
, who can we rely on for ongoing maintenance? Who is reviewing issues and PRs? Do we need to expand the list of collaborators?The text was updated successfully, but these errors were encountered: