-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving redux-devtools ecosystem to an org #394
Comments
ping @gaearon |
1 similar comment
ping @gaearon |
ping @gaearon 😞 |
Can't @zalmoxisus do it? |
@montogeek I guess he can't — he's not the owner of this repo. |
For future reference, I disabled GH ping notifications a long time ago because I get too much noise. Next time you need to contact me about something important please send a Twitter DM :-) If you set up an org I’ll happily transfer. |
OK, makes sense now. I'm not sure I could be entitled to set up an org, because my involvement in the devtools ecosystems just counts one PR. I don't feel lazy about this, just consider myself a ’stranger’ who should not be given too many rights in very important repos. You must know the guys who're actively involved in devtools today, could someone among them create the group? |
I wonder if we should set up a redux org? Unfortunately, both https://github.com/redux and https://github.com/reduxjs are taken. |
You’re organising the effort so it makes sense to me that you get the rights. It’s not about who wrote the most code. Organisational work is just as important. |
I took https://github.com/reduxjs early on just in case. It’s mine. Wanna move Redux there? |
Ah, cool! Let's do that. Can you add me to the org as an admin so I can do the transfer myself? I'll want to coordinate some things (URLs in package.json, gitbook setup, etc) and schedule it so it happens without too much issue or breakages. |
@timdorr Added you |
@romseguy @zalmoxisus could you add @timdorr to your repos so that he could move them? Or instead, could you be added to https://github.com/reduxjs and move the repos yourself? Their list should be in my first comment, but I could have missed something. |
LMK when the org is set up, and I can transfer my repos to it |
Can you make me an admin/owner/whatever? I'll click the right buttons to make it happen. |
Transferred repo to you |
Can you make me an org admin too? I'll get it over to the org and invite in the relevant folks. |
should be done |
OK, moved it over and invited @zalmoxisus in to the Dev Tools team |
Can @zalmoxisus and @romseguy request transfers of those repos into the @reduxjs org? I've added them both to the Dev Tools team, and I will make sure they maintain admin access to those repos. |
Submitting the form above I get " You don’t have the permission to create repositories on reduxjs” |
Oops, had that set wrong. Just checked the right box, so give it another go! |
@timdorr Do you mind if I also transfer |
Not at all. Anything Redux-y that you have under your personal account that you want to transfer over is totally fine. |
@romseguy thanks for moving redux-devtools-chart-monitor! Do you also mind migrating these two repos?
I have a pretty selfish reason for asking, which is reduxjs/d3-state-visualizer#13 😅 |
I moved d3-state-visualizer. redux-store-visualizer is just a demo of redux-devtools-chart-monitor, it could be deleted. |
Big thanks @romseguy! Also what is your view on npm publishing access for https://www.npmjs.com/package/d3-state-visualizer? |
I made @romseguy a maintainer of the Dev Tools team in the org, so he can add anyone else that should be included in there. I'll do the same for @zalmoxisus as soon as he accepts the invite :) |
@kachkaev you should now have push access to d3-state-visualizer and redux-devtools-chart-monitor on both npm and github. |
Shouldn't this be closed now? |
I created #412 about using a monorepo instead of moving all repositories. But we can move with this if others think it would be better. |
@romseguy we'll also need access to:
If we go with monorepo, no need to move everything to the org, just I'll need push access to npm (including the other 2 packages already moved to this org) and, after we merge the code, to add in description that it was moved to reduxjs/redux-devtools monorepo. I still have many critical issues to address, before starting that, so no rush with that. I'll also add @kachkaev as a collaborator to this repository. If we go with monorepo then probably should transfer those repositories back (instead of keeping them orphaned in the org)? We could maintain those outside if you want. |
Hi @gaearon,
I'm curious what you think about moving redux-devtools repos into a dedicated group, say https://github.com/redux-devtools. This idea has been discussed between @zalmoxisus, @romseguy and me here:
Both @zalmoxisus and @romseguy seem to support this move as you can see in the comments, however, this might take some time given that they are not visiting github very often these days. The migration of the repos may remove some pressure from the original authors and also help PRs like reduxjs/d3-state-visualizer#13 quicker propagate to the end users (the one I'm mentioning is over six months old).
If you're happy to move the main
redux-devtools
repo into a new org, at least these other repos could go there as well:BTW I'm not asking to become a part of the new group myself – I haven't contributed enough and I'm not sure I can take a long-term responsibility of a maintainer. However, I guess that a common place for the sister repos will help the community move the redux-devtools ecosystem forward! 🚀
WDYT?
The text was updated successfully, but these errors were encountered: