Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-json-tree dependency woes #587

Closed
akx opened this issue Aug 14, 2020 · 2 comments
Closed

react-json-tree dependency woes #587

akx opened this issue Aug 14, 2020 · 2 comments

Comments

@akx
Copy link

akx commented Aug 14, 2020

Following up on #490.

react-json-tree has a dependency on https://github.com/alexkuz/react-base16-styling:

"react-base16-styling": "^0.6.0"

However, as reported in alexkuz/react-base16-styling#2, it's packaged in a way that it implicitly depends on babel-runtime, which means software using the newly released react-json-tree will not correctly build unless a version of babel-runtime is expressly added as a dependency. I submitted a PR alexkuz/react-base16-styling#11 that should eventually fix this.

I also noticed a version of react-base16-styling has been vendored into this repo; it already drops the runtime transform, so I guess I don't need to make another PR against this repo.

What's the story here (@Methuselah96, you seem to be the mastermind here 😄) – can we e.g. expect a @reduxjs/react-base16-styling sometime soon, and hopefully a react-json-tree with that dependency?

@Methuselah96
Copy link
Member

I just did a publish (including react-base16-styling). Let me know if that fixes your issue.

@Methuselah96
Copy link
Member

Closing for now. Feel free to followup if this isn't resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants