From 85fa1d099a369dbacc991e4d9c7049e1dd23ba7a Mon Sep 17 00:00:00 2001
From: mkumbobeaty <charsbeaty@gmail.com>
Date: Tue, 5 Nov 2024 10:07:36 +0300
Subject: [PATCH] update timeline modal

---
 web/src/beta/ui/fields/TimePeriodField/EditModal.tsx | 3 ---
 web/src/beta/ui/fields/TimePeriodField/hooks.ts      | 6 ++----
 web/src/beta/ui/fields/TimePeriodField/index.tsx     | 6 ++----
 3 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/web/src/beta/ui/fields/TimePeriodField/EditModal.tsx b/web/src/beta/ui/fields/TimePeriodField/EditModal.tsx
index 69aa5a1778..d9e78b9d05 100644
--- a/web/src/beta/ui/fields/TimePeriodField/EditModal.tsx
+++ b/web/src/beta/ui/fields/TimePeriodField/EditModal.tsx
@@ -15,13 +15,11 @@ type EditPanelProps = {
   timePeriodValues?: TimePeriodFieldProp;
   onClose?: () => void;
   onChange?: (value?: TimePeriodFieldProp) => void;
-  setTimePeriodValues?: (value?: TimePeriodFieldProp) => void;
 };
 
 const EditModal: FC<EditPanelProps> = ({
   visible,
   timePeriodValues,
-  setTimePeriodValues,
   onClose,
   onChange
 }) => {
@@ -38,7 +36,6 @@ const EditModal: FC<EditPanelProps> = ({
     timePeriodValues,
     onChange,
     onClose,
-    setTimePeriodValues
   });
 
   const timezoneMatches = useMemo(() => {
diff --git a/web/src/beta/ui/fields/TimePeriodField/hooks.ts b/web/src/beta/ui/fields/TimePeriodField/hooks.ts
index 4c121633da..60a8552814 100644
--- a/web/src/beta/ui/fields/TimePeriodField/hooks.ts
+++ b/web/src/beta/ui/fields/TimePeriodField/hooks.ts
@@ -6,14 +6,12 @@ type Props = {
   timePeriodValues?: TimePeriodFieldProp;
   onChange?: (value?: TimePeriodFieldProp) => void;
   onClose?: () => void;
-  setTimePeriodValues?: (value?: TimePeriodFieldProp) => void;
 };
 
 export default ({
   timePeriodValues,
   onChange,
   onClose,
-  setTimePeriodValues
 }: Props) => {
   const [warning, setWarning] = useState(false);
 
@@ -59,9 +57,9 @@ export default ({
         default:
           break;
       }
-      setTimePeriodValues?.(updatedData);
+      onChange?.(updatedData);
     },
-    [timePeriodValues, setTimePeriodValues]
+    [timePeriodValues, onChange]
   );
 
   const [disabledFields, setDisabledFields] = useState<string[]>([]);
diff --git a/web/src/beta/ui/fields/TimePeriodField/index.tsx b/web/src/beta/ui/fields/TimePeriodField/index.tsx
index 50e35ef1b6..a1de603c33 100644
--- a/web/src/beta/ui/fields/TimePeriodField/index.tsx
+++ b/web/src/beta/ui/fields/TimePeriodField/index.tsx
@@ -33,15 +33,14 @@ const TimePeriodField: FC<TimePeriodFieldProps> = ({
   const handleEditorModalClose = useCallback(() => {
     setOpenEditModal(false);
     if (!value) {
-      setTimePeriodValues(undefined);
+      onChange?.(undefined);
     }
-  }, [value]);
+  }, [onChange, value]);
 
   const handleEditorModalOpen = useCallback(() => setOpenEditModal(true), []);
 
   const handleTimePeriodSettingDelete = useCallback(() => {
     if (!value) return;
-    setTimePeriodValues(undefined);
     onChange?.();
   }, [value, onChange]);
 
@@ -114,7 +113,6 @@ const TimePeriodField: FC<TimePeriodFieldProps> = ({
           onChange={onChange}
           onClose={handleEditorModalClose}
           visible={openEditModal}
-          setTimePeriodValues={setTimePeriodValues}
         />
       )}
     </CommonField>