-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): add missing UNSAFE_PLUGIN_URLS
and BRAND
environment variable
#1297
Conversation
Signed-off-by: KeisukeYamashita <[email protected]>
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces modifications to the Dockerfile and a JSON template. Two new environment variables, Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: KeisukeYamashita <[email protected]>
UNSAFE_PLUGIN_URLS
environment variableUNSAFE_PLUGIN_URLS
and BRAND
environment variable
Overview
I added an environment variable that will be propagated to
reearth_config.json
'sunsafePluginUrls
property.What I've done
As the title says.
What I haven't done
How I tested
Which point I want you to review particularly
Memo
Summary by CodeRabbit
New Features
REEARTH_WEB_BRAND
andREEARTH_WEB_UNSAFE_PLUGIN_URLS
."brand"
and"unsafePluginUrls"
.Bug Fixes