Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): GlobalModal not showing when it should #857

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Dec 12, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 6f20fe0
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/6578eecb41785b00087e8e39
😎 Deploy Preview https://deploy-preview-857--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #857 (6f20fe0) into main (5740377) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   25.61%   25.61%   -0.01%     
==========================================
  Files        1644     1644              
  Lines      180770   180772       +2     
  Branches     3920     3919       -1     
==========================================
- Hits        46301    46298       -3     
- Misses     133380   133385       +5     
  Partials     1089     1089              
Flag Coverage Δ
web 23.82% <0.00%> (-0.01%) ⬇️
web-beta 23.82% <0.00%> (-0.01%) ⬇️
web-classic 23.82% <0.00%> (-0.01%) ⬇️
web-utils 23.82% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/pages/Page.tsx 0.00% <ø> (ø)
web/src/app.tsx 0.00% <0.00%> (ø)
web/src/beta/features/GlobalModal/index.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@KaWaite KaWaite merged commit 8df7d07 into main Dec 12, 2023
@KaWaite KaWaite deleted the fix-global-modal branch December 12, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant