Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: front-end for new authentication system #102

Merged
merged 21 commits into from
Oct 21, 2021
Merged

feat: front-end for new authentication system #102

merged 21 commits into from
Oct 21, 2021

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Oct 13, 2021

Overview

The new authentication system will allow developers to use built-in log in, sign up, and reset password pages. This is the basic foundation + log in page.

What I've done

  • New RootPage that shows a loader before redirecting the user to the login page url specified on the back-end.
  • Log in page
  • Removed TopPage files

What I haven't done

  • No Signup page
  • No Reset page
  • Log in page has links to both signup and reset pages and Re:Earth's back-end isn't setup for using the Login page yet so the Login component is commented out

Screenshot

Screen Shot 2021-10-19 at 11 00 33

Screen Shot 2021-10-19 at 14 32 10

@netlify
Copy link

netlify bot commented Oct 13, 2021

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: 86986bc

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61710888f8eac3000746dc36

😎 Browse the preview: https://deploy-preview-102--reearth-web.netlify.app

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #102 (86986bc) into main (bea1a32) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   53.53%   53.53%           
=======================================
  Files          48       48           
  Lines         891      891           
  Branches      119      119           
=======================================
  Hits          477      477           
  Misses        364      364           
  Partials       50       50           
Impacted Files Coverage Δ
src/theme/darkTheme.ts 100.00% <ø> (ø)
src/theme/lightheme.ts 100.00% <ø> (ø)
src/theme/theme.ts 100.00% <ø> (ø)

@KaWaite KaWaite marked this pull request as ready for review October 19, 2021 05:54
Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of comments.
Plz have a look. Mostly fine!

Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tweak the gradient color of background of login page
  • Will implementation of sign up and password reset screen be done in another PR?

rot1024
rot1024 previously approved these changes Oct 21, 2021
Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaWaite KaWaite merged commit 964d925 into main Oct 21, 2021
@KaWaite KaWaite deleted the feat/auth branch October 21, 2021 06:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants