Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: bug bounty #2 #105

Merged
merged 10 commits into from
Oct 21, 2021
Merged

fix: bug bounty #2 #105

merged 10 commits into from
Oct 21, 2021

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Oct 20, 2021

What I've done

  • Fix drop down bug where Workspace drop down would migrate right if a long named workspace is added
  • Moved the colorful Re:Earth icon into icons and stop using it directly (should solve issue where icon would flicker when changing pages in the settings)
  • updated some language
  • avoid in multiple places long Workspace names overflowing by eclipsing them
  • Refactored and fixed up members list UI + fixed issue where searched for member couldn't be removed from the list in the Workspace settings page.

@netlify
Copy link

netlify bot commented Oct 20, 2021

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: b692955

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/617132f970601000089c1909

😎 Browse the preview: https://deploy-preview-105--reearth-web.netlify.app

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #105 (b692955) into main (964d925) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   53.53%   53.53%           
=======================================
  Files          48       48           
  Lines         891      891           
  Branches      119      119           
=======================================
  Hits          477      477           
  Misses        364      364           
  Partials       50       50           

@KaWaite KaWaite marked this pull request as ready for review October 21, 2021 01:26
rot1024
rot1024 previously approved these changes Oct 21, 2021
Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine.

@KaWaite KaWaite merged commit da48150 into main Oct 21, 2021
@KaWaite KaWaite deleted the fix-bugs-10-19 branch October 21, 2021 09:33
keiya01 pushed a commit that referenced this pull request Apr 25, 2023
* refactor gql

* refactor context

* rename
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants