Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: project setting page does not display correctly after creating a new project #127

Merged
merged 5 commits into from
Nov 11, 2021

Conversation

issmail-basel
Copy link
Contributor

@issmail-basel issmail-basel commented Nov 9, 2021

Overview

Project setting page does not display correctly after creating a new project

To Reproduce

  1. Create a new project
  2. Jump to the setting page of the project newly created (do not show editor page)
  3. Project name and left menus of the project doesn't display (reloading fixes it)

What I've done

I've used the same project query in dashboard page as in settings page and same which is used in (refetch), so now refetch works fine as expected.

How I tested

  1. Create a new project
  2. Jump to the setting page of the project newly created (do not show editor page)
  3. Project name and left menus of the project displays fine

Screenshot

Screencast.2021-11-10.07.25.05.mp4

t

@netlify
Copy link

netlify bot commented Nov 9, 2021

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: d73ee74

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/618cd39beb092100082a2e51

😎 Browse the preview: https://deploy-preview-127--reearth-web.netlify.app

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #127 (d73ee74) into main (fbf6e9d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   44.54%   44.54%           
=======================================
  Files          56       56           
  Lines        1109     1109           
  Branches      179      179           
=======================================
  Hits          494      494           
  Misses        562      562           
  Partials       53       53           
Impacted Files Coverage Δ
src/gql/graphql-client-api.tsx 36.87% <ø> (ø)

@issmail-basel issmail-basel marked this pull request as ready for review November 10, 2021 07:01
Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Videos are helpful to understand the situation. Thank you!

@issmail-basel issmail-basel merged commit c120dcc into main Nov 11, 2021
@issmail-basel issmail-basel deleted the bug-project-creation branch November 11, 2021 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants