This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: position label in front of billboard #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: 0cc2daf 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61bcfeab01322c0008a5fbd0 😎 Browse the preview: https://deploy-preview-147--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 45.48% 45.48%
=======================================
Files 60 60
Lines 1284 1284
Branches 205 205
=======================================
Hits 584 584
Misses 641 641
Partials 59 59 |
rot1024
approved these changes
Dec 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Labels aren't displayed correctly, because labels and billboard are on the same level as billboards
What I've done
Added a small
eyeOffsetto the label so it renders in front of the billboardSolution according to Label positioned behind billboard/point
Screenshot
Old:
New:
