This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: cluster styling issue #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: bdcc24b 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61ee3fdf24c5e90007fba8f8 😎 Browse the preview: https://deploy-preview-161--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 45.39% 45.39%
=======================================
Files 60 60
Lines 1302 1302
Branches 207 207
=======================================
Hits 591 591
Misses 652 652
Partials 59 59 |
rot1024
suggested changes
Jan 21, 2022
rot1024
reviewed
Jan 21, 2022
rot1024
approved these changes
Jan 21, 2022
HideBa
approved these changes
Jan 24, 2022
keiya01
added a commit
that referenced
this pull request
Apr 25, 2023
* feat: setup timeline buitlin widget * fix: enable singleOnly flag * fix: improve description * Update pkg/builtin/manifest_ja.yml Co-authored-by: rot1024 <[email protected]> Co-authored-by: rot1024 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Pixel rangeis changed, cluster styling breaksMinimum cluster sizeis not working as expected.UseEffectis in a infinite loop.What I've done
Minimum cluster sizeis larger than number of cluster layers, without breaking the event listener.What I haven't done
How I tested
pixel range, cluster should not break.Minimum cluster sizeto be larger than number of cluster layers.Screenshot
Before:
After: