This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: refine setting page #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lavalse
commented
Jun 18, 2021
lavalse
commented
- update the setting page with new design ( new narvigation with responsive react, new structure )
- update asset library page with Assets Container component, and fix bugs
- update projects workspaces list page
- update properties filed style
…iner to work in both modal and settings
…roject list not updating bug
to catchup the main branch, need to merge the main
fix auth0 loop bug
rot1024
suggested changes
Jun 18, 2021
src/components/molecules/Common/AssetModal/AssetContainer/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Common/AssetModal/AssetContainer/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Common/AssetModal/AssetContainer/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Common/AssetModal/AssetContainer/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Common/AssetModal/VirtualAssetCard/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Common/AssetModal/VirtualAssetCard/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Common/AssetModal/VirtualAssetCard/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Common/AssetModal/AssetContainer/index.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 52.25% 52.25%
=======================================
Files 45 45
Lines 643 643
Branches 125 125
=======================================
Hits 336 336
Misses 232 232
Partials 75 75
|
KaWaite
reviewed
Jun 18, 2021
KaWaite
reviewed
Jun 22, 2021
src/components/molecules/Settings/Account/AccountSection/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jun 22, 2021
KaWaite
reviewed
Jun 22, 2021
src/components/molecules/Settings/ProjectList/ProjectCell/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Jun 22, 2021
KaWaite
reviewed
Jun 24, 2021
KaWaite
reviewed
Jun 24, 2021
HideBa
previously approved these changes
Jun 25, 2021
merge new update to branch
rot1024
approved these changes
Jul 1, 2021
KaWaite
reviewed
Jul 1, 2021
KaWaite
reviewed
Jul 1, 2021
KaWaite
approved these changes
Jul 1, 2021
keiya01
pushed a commit
that referenced
this pull request
Apr 25, 2023
* wip: align system domain models; structs, getters for each level, add function and remove function + testing for all so far * wip: add WidgetLayout field to plugins; update plugin_manifest, generate types, update convert.go, update extension.go as well as its builder and tests * Add graphql types for widgetlayout, update graphql plugin conversion * Add floating parameter to WidgetLayout to be able to filter widgets that aren't related to the align system. fixed conversion logic for empty WidgetLayout fixed conversion logic for empty DefaultLocation * Change align_system name to widget_align_system * Move WidgetLayout to scene package Update plugin.WidgetLayout use and add WidgetLayout where necessary * convert if/else chains to switches add Move method * Make widgetLayout a pointer * Fix Remove method, add Reorder method, tests for both move and reorder, fix up tests * wip: add widget align system to usecases/graphql * Remove unneeded widgetlayout in AddWidgetInput Pull out widgetlayout and conditionally add widget to widgetalignsystem in AddWidget Add SetExtended method to Widget Add extended to UpdateWidgetParam Combine Move and Reorder methods + tests * Change defaultLocation to currentLocation Add WidgetIds and Alignment methods to alignSystem Update graphql Etc * Add SetCurrentLocation method Make widgetIds a slice of pointers to the ids Update add test to include two additions Update logic in scene interactor to be more deliberate Update scene controller to avoid assignment if nil * Conversions for mongo and structs Conversions for graphql and structs Updated graphql schemas + gens * Add comments to functions that didn't have them for what they do * Add alignment to graphql and mongodoc simplify conditionals/avoid lint warning * Re-rename currentLocation to defaultLocation Add align to widget update Add widgetLayout to reearth widgets Fix/improve conditionals * Remove unneeded conditional check * Add align sys and widgetlayout to published JSON Add extended bool to sceneWidget (graphql) Move up updating align to top of if statements Add Equal method to widgetId * Migration for adding widgetLayout to scene Migration for adding alignSystem to scene * Fix migration to get correct widgetlayout from manifest * Remove unused type in scene encoder Remove commented out code in scene builder * Add conditional in case widgetlayout is nil * Fix tests * Rename scene Location to WidgetLocation Rename graphql Location to WidgetLocation Rename mongodoc Location to WidgetLocation Fix where mongodoc PluginExtensionDoc type used a type from pkg Create a function to handle recreating widget align system in mongodoc and scene builder Update tests to include widget layout * Fix mongodoc plugin indentation Rename toStruct to stringsToWidgetIDs for clarity Remove error from ToModelAlignSystem since errors will never be created Remove comments in pkg/scene/builder.go * Remove location from RemoveWidgetInput and related Add find function to find location of a widget * Simplify WidgetLayoutInput only has location and index Make mandatory id params not pointers Fix bug with converting to mongo document where all sections were saving as the same Simplify method names in widget align system Update methods to work without needing a location * Update naming for clarity Cleanup code style for clarity Add WidgetLayout values to better test code * Replace plugId and extensionId with widgetId WidgetIds -> WidgetIDs * Add consts for align values Include switch case for assign align value * Update WZone, etc to WidgetZoneType style Regenerate graphql * Fix align value in a test (should only be start, center or end now) * Cleanup UpdateWidget controller Fix code readability Rename to WidgetLocationDocument Add new methods to WidgetArea Reorganize align sys domain code * Cleanup schema.graphql Make widgetIDs not pointers * Update align sys consts to WidgetXX Rename types in mongodc to XXDocument Remove old comments Cleanup code Use consts instead of strings * widgetlayouts floating field is necessary widgetLayouts extended extendable are not use consts instead of hardcoded values Location is necessary for adding widgets * test for manifest pkgs layout method * add tests in plugin/manifest and scene * refactor * Separate Widget zone, section and area logic. Fix Find method to be up to standards. Add Id and floating to widgetJSON. Fix issue with conversion funcs where they were converting to all the same Section. * Fix migrations for pointer values * Fix widget align sys remove test Add tests for WidgetArea, Section and Zone * Add tests to scene builder, align system and widget zone * Remove unwanted assignment to align on update * Add return if findwidgetlocation is returns nil. Fix test with race condition error. * Fix where updating extended would also add widget again. * Fix extending conditional * Change extendable from bool to object with vert and hor * Fixes from PR review * FindWidgetLocation method now returns int, -1 instead of nil. Add New___ methods for Zone, Section and Area. Update tests. * Fix SetExtended method * Add tests for align system and widget area. * Avoid race condition in test * Add tests to widget section * Add test to widget section * Add Extendable to published scene * Update schema.graphql Co-authored-by: rot1024 <[email protected]> * Clean up tests. Fix Add and AddAll methods so they don't directly manipulate from WidgetAlignSystem. * Make convert functions public * Merge with main * Type widget area vars with named types * Type widget section vars * Type widget zone constants * type WidgetLocation with WidgetZoneType * Replace zone being typed as string with WidgetZoneType * Type WidgetLocations section and area, Fix nil pointer errors. * type alignments with WidgetAlignType * Clean up widget area and zone tests * refactor * pair programming * pair pro * pair pro * pair pro * pair pro Co-authored-by: KaWaite <[email protected]> * pair pro Co-authored-by: KaWaite <[email protected]> Co-authored-by: HideBa <[email protected]> * pair pro (usecase) * add setters Co-authored-by: KaWaite <[email protected]> Co-authored-by: HideBa <[email protected]> * typo * rename and add nil check * reimpl mongo * rename file * update gql * fix * align CENTER -> CENTERED * Revert Widget zone, section, area to optional in graphql * Make Menu widget legacy, add Button widget to manifest * Update manifest.yml Co-authored-by: KaWaite <[email protected]> Co-authored-by: rot1024 <[email protected]> Co-authored-by: KaWaite <[email protected]> Co-authored-by: HideBa <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.