Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: menu button width #21

Merged
merged 3 commits into from
Jun 25, 2021
Merged

fix: menu button width #21

merged 3 commits into from
Jun 25, 2021

Conversation

issmail-basel
Copy link
Contributor

@issmail-basel issmail-basel commented Jun 23, 2021

Overview

When the menu has been opened the style should be kept well

What I've done

I made the menu min-width of 200px
but if the button is wider the menu will take the whole width (as shown in the screenshots)

Screenshot

1
2

Which point I want you to review particularly

Memo

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #21 (d7c5820) into main (38a69ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   52.25%   52.25%           
=======================================
  Files          45       45           
  Lines         643      643           
  Branches      125      125           
=======================================
  Hits          336      336           
  Misses        232      232           
  Partials       75       75           

@issmail-basel issmail-basel changed the title bug: fix menu button fix: menu button width Jun 24, 2021
@issmail-basel issmail-basel marked this pull request as ready for review June 24, 2021 08:23
@issmail-basel issmail-basel requested review from KaWaite and HideBa June 24, 2021 08:23
Copy link
Member

@HideBa HideBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as @lavalse approves how it looks, looks good to me!

@issmail-basel issmail-basel requested a review from lavalse June 24, 2021 09:07
Copy link
Member

@lavalse lavalse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for me

@issmail-basel issmail-basel merged commit d08ebac into main Jun 25, 2021
@issmail-basel issmail-basel deleted the bug/menu-button branch June 25, 2021 08:49
keiya01 pushed a commit that referenced this pull request Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants