This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: public settings page #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 52.15% 52.18% +0.02%
==========================================
Files 45 45
Lines 650 642 -8
Branches 125 125
==========================================
- Hits 339 335 -4
+ Misses 237 233 -4
Partials 74 74
|
rot1024
force-pushed
the
main
branch
2 times, most recently
from
0752537 to
21b167f
Compare
added 5 commits
July 16, 2021 15:19
add public settings page
public fields update header info
update language
KaWaite
force-pushed
the
feat-public-settings
branch
from
22a5b87 to
f11ae4c
Compare
rot1024
suggested changes
Jul 16, 2021
src/components/molecules/Settings/Project/Dataset/DatasetSection/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Settings/Project/Dataset/DatasetSection/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Settings/Project/PublishSection/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Settings/Project/PublishSection/index.tsx
Outdated
Show resolved
Hide resolved
src/components/molecules/Settings/Project/PublishSection/index.tsx
Outdated
Show resolved
Hide resolved
…on/index.tsx Co-authored-by: rot1024 <[email protected]>
…on/index.tsx Co-authored-by: rot1024 <[email protected]>
….tsx Co-authored-by: rot1024 <[email protected]>
….tsx Co-authored-by: rot1024 <[email protected]>
….tsx Co-authored-by: rot1024 <[email protected]>
rot1024
approved these changes
Jul 16, 2021
HideBa
approved these changes
Jul 16, 2021
keiya01
pushed a commit
that referenced
this pull request
Apr 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Main idea is to split project settings into project and public.
What I've done
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo