This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: support multi-line infobox titles #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaWaite
approved these changes
Jul 16, 2021
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage 52.15% 52.15%
=======================================
Files 45 45
Lines 650 650
Branches 125 125
=======================================
Hits 339 339
Misses 237 237
Partials 74 74 |
HideBa
approved these changes
Jul 16, 2021
|
@rot1024 Is this valid on published page as well? |
|
I made changes in InfoBoxFrame and it is used by both InfoBox and SimpleInfoBox so it should work in published pages, but not testable. (I will work on it next) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
Support multi-line infobox titles. Long word will also break automatically.
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
Memo