This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: draggable layer #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: c364e4b 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/616f9c97586e7000083f95a3 😎 Browse the preview: https://deploy-preview-58--reearth-web.netlify.app |
KaWaite
reviewed
Sep 10, 2021
KaWaite
reviewed
Sep 10, 2021
KaWaite
reviewed
Sep 10, 2021
KaWaite
reviewed
Sep 10, 2021
KaWaite
reviewed
Sep 10, 2021
KaWaite
reviewed
Sep 10, 2021
|
For me, I still feel the performance is not good enough after changing the maker's location, and the fps just come to less than 20 every time I rotate the earth. If we should test on a better back-end environment, just merge to main, see what will happen. |
lavalse
previously approved these changes
Oct 20, 2021
…r different property keys, delete console.log
rot1024
previously approved these changes
Oct 20, 2021
keiya01
pushed a commit
that referenced
this pull request
Apr 25, 2023
* feat: tag system domain models (#39) * feat: tag system domain models * refactor: * add tag interface * tag -> group and tag->item conversation * testing: generate test cases for the tagID * resolve notes * fix unit tests errors * add NewId test code fix NewId func * add more test cases refactor some parts * feat: tag system data-layer (mongo) (#44) * feat: tag system data-layer (mongo) * remove len > 0 check * goimport * Update pkg/tag/group_builder.go Co-authored-by: rot1024 <[email protected]> * Update pkg/tag/item_builder.go Co-authored-by: rot1024 <[email protected]> * rename itemFrom and groupFrom funcs Co-authored-by: rot1024 <[email protected]> * feat: create tag group and tag item (#45) * tag item and group schema * feat: creat tags (GQL schema) * tag items and tag groups resolvers * datalayer (dummy memory) and usecases * receive list by reference * check if nil for list * resolve notes * generate new models * feat: memory infrastructure (#46) * refactor: implement memory infrastructure * test: implement memory infrastructure test cases * test: fix FindByScene test case * feat: attach/detach tag from layer (#50) * tag item and group schema * feat: creat tags (GQL schema) * tag items and tag groups resolvers * datalayer (dummy memory) and usecases * receive list by reference * check if nil for list * feat: introduce tags to layers * feat: attach/detach tags from layers * fix imports * refactor: resolve notes * test: test units for tags * refactor: resolve notes * feat: attach/detach tag item from group (#52) * refactor: transform group tags list to reference * feat: attach/detach tags * refactor: use params as use-case input * test: mongodoc testing (#61) * test: mongodoc testing * resolve notes * feat: remove tag (#58) * feat: remove a tag (init) * feat: remove tag * feat: remove tag usecase and infra * resolve notes * feat: tag system queries (#54) * feat: tag system queries * resolve notes * feat: update tag (#49) * tag item and group schema * feat: creat tags (GQL schema) * tag items and tag groups resolvers * datalayer (dummy memory) and usecases * receive list by reference * check if nil for list * feat: rename tag group * refactor: rename -> update * resolve notes * resolve notes * change find by id func return type * Merge branch 'tag-system' of https://github.com/reearth/reearth-backend into tag/update-group-label # Conflicts: # internal/adapter/gql/generated.go # internal/adapter/gql/gqlmodel/convert_tag.go * fix testing * resolve notes * resolve notes * resolve notes Co-authored-by: HideBa <[email protected]> Co-authored-by: rot1024 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
What I haven't done
How I tested
Screenshot
Which point do I want you to review particularly
ScreenSpaceCameraController.enableRotateshould be kept after DnD bycesium-dnd, but it's locked. I deliberately enable to rotate when the layer is dropped. If you have any idea to improve it.Memo