-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: use jotai instead of redux #68
Conversation
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: 8d6e2fb 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61285392af9fc800076c7f69 😎 Browse the preview: https://deploy-preview-68--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 57.98% 58.10% +0.12%
==========================================
Files 42 40 -2
Lines 664 685 +21
Branches 94 96 +2
==========================================
+ Hits 385 398 +13
- Misses 236 245 +9
+ Partials 43 42 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
But I checked the preview env very briefly and it seems like Scene isn't selected on load so the right panel is blank when the Earth Editor is first opened.
I have also seen that behavior, but when I select a scene, the scene settings are displayed, and there is no noticeable abnormal behavior. This seems to be the expected behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since redux is an over-technology for the current use case, we will replace it with another state management library "jotai" to reduce the number of dependent libraries and optimize the bundled JS size.