-
Notifications
You must be signed in to change notification settings - Fork 12
feat: support dataset schema preview and create layer group from selected primitive type #74
Conversation
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: 55c0462 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/618ddfde593d590007814282 😎 Browse the preview: https://deploy-preview-74--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 44.54% 44.42% -0.13%
==========================================
Files 56 56
Lines 1109 1121 +12
Branches 179 179
==========================================
+ Hits 494 498 +4
- Misses 562 570 +8
Partials 53 53
|
…b into refine-dataset-import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job seems fine nothing critical
I will double check for comments if found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have test the basic function, works good for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation is ok
- Resolve conflicts
- Change the PR title so everyone can know more details in CHANGELOG
…th/reearth-web into refine-dataset-import
* feat: cluster domain models (#69) * Co-authored-by: mimoham24 <[email protected]> * feat: domain models * add cluster extenstion type * add cluster extension type test case * fix cluster layers * resolve notes * update manifest * fix manifest.yml margin * refactor models * resolve notes * fix manifest file * resolve notes * resolve notes Co-authored-by: HideBa <[email protected]> * feat: cluster datalayer (#73) * feat: cluster graphql/mongo (#74) * feat: cluster datalayer * feat: cluster CRUD * resolve notes * resolve notes * add test cases Co-authored-by: HideBa <[email protected]>
Overview
What I've done
table
componentWhat I haven't done
How I tested
Screenshot
review particularly
Memo