This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: widget bugs, language #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix uninstall plugin modal language. Fix Menu(legacy) on mobile. Fix Storytelling many stories menu issue.
|
❌ Deploy Preview for reearth-web failed. 🔨 Explore the source changes: 1bdebbd 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61553b938f5f8200080283aa |
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 60.07% 60.07%
=======================================
Files 48 48
Lines 784 784
Branches 117 117
=======================================
Hits 471 471
Misses 263 263
Partials 50 50 |
rot1024
suggested changes
Sep 28, 2021
Co-authored-by: rot1024 <[email protected]>
Co-authored-by: rot1024 <[email protected]>
keiya01
pushed a commit
that referenced
this pull request
Apr 25, 2023
Co-authored-by: maherhamoui6 <[email protected]> Co-authored-by: yk <[email protected]> Co-authored-by: basel.issmail <[email protected]> Co-authored-by: rot1024 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Couple bug fixes and a language update
What I've done
Fix uninstall plugin modal language.
Fix Menu(legacy) on mobile (button titles would get squished). Now buttons wrap.
Fix Storytelling many stories menu issue. (The more stories you added, the further the menu would move away from the widget's core.