Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: enhance extended field of widget in plugin API #90

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Sep 29, 2021

Overview

What I've done

type Widget {
  extended: boolean;
}

type Widget {
  extended?: { horizontally: boolean; vertically: boolean; };
}

image

How I tested

Manually

@netlify
Copy link

netlify bot commented Sep 29, 2021

❌ Deploy Preview for reearth-web failed.

🔨 Explore the source changes: a0362ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/6153ebbbd832dc0007e2d647

@rot1024 rot1024 requested review from HideBa and KaWaite and removed request for HideBa September 29, 2021 04:32
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #90 (a0362ca) into main (97f74e9) will increase coverage by 0.10%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   59.97%   60.07%   +0.10%     
==========================================
  Files          48       48              
  Lines         782      784       +2     
  Branches      117      117              
==========================================
+ Hits          469      471       +2     
  Misses        263      263              
  Partials       50       50              
Impacted Files Coverage Δ
src/components/atoms/Plugin/IFrame/index.tsx 75.00% <ø> (+32.14%) ⬆️
src/components/atoms/Plugin/IFrame/hooks.ts 48.07% <40.00%> (-0.86%) ⬇️

Copy link
Member

@KaWaite KaWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one place I am not sure works the way it should.

@rot1024 rot1024 merged commit 06cb14e into main Sep 30, 2021
@rot1024 rot1024 deleted the feat/widget-plugin-api-extended branch September 30, 2021 01:54
keiya01 pushed a commit that referenced this pull request Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants