Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: navigator.language should be used as fallback lang #91

Merged
merged 10 commits into from
Oct 4, 2021

Conversation

rot1024
Copy link
Member

@rot1024 rot1024 commented Sep 29, 2021

reearth/reearth-visualizer#112

  • Pass lang argument to translated* fields in queries
  • Fix fallback language
  • Clear cache after any plugin was installed or uninstalled

@netlify
Copy link

netlify bot commented Sep 29, 2021

❌ Deploy Preview for reearth-web failed.

🔨 Explore the source changes: 108cd97

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/615acba05219a8000826f139

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #91 (108cd97) into main (a9cc232) will decrease coverage by 6.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   60.07%   53.43%   -6.65%     
==========================================
  Files          48       48              
  Lines         784      889     +105     
  Branches      117      117              
==========================================
+ Hits          471      475       +4     
- Misses        263      364     +101     
  Partials       50       50              
Impacted Files Coverage Δ
...rc/components/molecules/Visualizer/Layers/store.ts 88.00% <ø> (ø)
src/gql/graphql-client-api.tsx 36.87% <ø> (-16.37%) ⬇️
src/locale/locale.ts 85.71% <100.00%> (+2.38%) ⬆️

@rot1024 rot1024 marked this pull request as ready for review October 4, 2021 08:06
@rot1024 rot1024 changed the title fix: navigator.language should be used as default lang fix: navigator.language should be used as fallback lang Oct 4, 2021
@rot1024 rot1024 merged commit 15df163 into main Oct 4, 2021
@rot1024 rot1024 deleted the fix/default-lang branch October 4, 2021 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants