Changes not tracked properly on instance pulled from collection

[derekprior]

Consider:

u = User.all.first
u.changes

One would expect changes to be empty, but in fact every field is marked as changed. However:

u = User.find(1)
u.changes

Is empty as one would expect.

[chewi]

This happens for singular records returned from an association too.

[paulvt]

Indeed, clearing @changed_attributes is missing in several places. I have added for resource in Her::Model::Attributes.initialize_collection, but this doesn't solve it for single resource associations.

[paulvt]

Also added a clear to the fetch method of the various associations and now everything seems to be fine. When I have time I will prepare a pull request.

[chewi]

@paulvt, did you see my fix in #298? It should handle all cases.

[paulvt]

I overlooked your pull request, cheers!
This is much more elegant than clearing it all over the place. (I am still getting to grips with the intricate structure of model, relation, association, proxy, etc.)

[kvaggelakos]

I can confirm that this is still an issue. Doesn't seem like @chewi's PR has been merged yet.