chore(playground): add playground #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machour
reviewed
Apr 6, 2022
|
This looks fantastic. I got this on my first attempt: |
|
I've fixed it! |
|
Confusingly the bug-report integration test failed on this one 🤔 Going to kick it off again and hopefully it fails again. Much happier with something that fails consistently than passes inconsistently 😅 EDIT: It passed... well that's unfortunate 😬 Hopefully Logan's changes to playwright magically make our tests more reliable. |
|
Awesome, it's working! I love the rebuild when you change both the playground app and the remix source. It's perfect. Live reload is busted though, I get this in the browser |
There was a problem hiding this comment.
Seems like we're using indie-stack (?) as the template here.
Having it inline is nice as we don't have to download it from upstream.
On the other hand we're missing on all latest changes that are happening over there and could be useful to have here too.
Just wanted to bring it to your attention that it can cause extra maintenance work.
|
This isn't exactly the same as the indie stack. The express server has an important difference. |
|
@ryanflorence that was a bug in remix. This has been fixed. I updated this branch with dev and it should be ready to go. |
MichaelDeBoey
approved these changes
Apr 7, 2022
Co-authored-by: Michaël De Boey <[email protected]>
ryanflorence
force-pushed
the
playground
branch
2 times, most recently
from
1393fcc to
17fac4d
Compare
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://linear.app/remix-run/issue/REM-959/work-on-remix-repo-playground
- [ ] TestsCheck the updates to Contributing.md for details