From 380e385de926ebd3e3c60fe24c3829ba43e13b5d Mon Sep 17 00:00:00 2001 From: Matt Brophy Date: Wed, 22 Mar 2023 15:36:44 -0400 Subject: [PATCH 1/4] Add deprecation warning for v2_meta --- packages/remix-dev/__tests__/create-test.ts | 3 +++ packages/remix-dev/config.ts | 9 +++++++++ 2 files changed, 12 insertions(+) diff --git a/packages/remix-dev/__tests__/create-test.ts b/packages/remix-dev/__tests__/create-test.ts index c905ad83d09..9640bcaff1a 100644 --- a/packages/remix-dev/__tests__/create-test.ts +++ b/packages/remix-dev/__tests__/create-test.ts @@ -12,6 +12,7 @@ import { errorBoundaryWarning, flatRoutesWarning, formMethodWarning, + metaWarning, } from "../config"; beforeAll(() => server.listen({ onUnhandledRequest: "error" })); @@ -356,6 +357,8 @@ describe("the create command", () => { "\n" + formMethodWarning + "\n" + + metaWarning + + "\n" + flatRoutesWarning + "\n\n" + getOptOutOfInstallMessage() + diff --git a/packages/remix-dev/config.ts b/packages/remix-dev/config.ts index 3331b5c00c1..c4746d1dc84 100644 --- a/packages/remix-dev/config.ts +++ b/packages/remix-dev/config.ts @@ -415,6 +415,10 @@ export async function readConfig( warnOnce(formMethodWarning, "v2_normalizeFormMethod"); } + if (!appConfig.future?.v2_meta) { + warnOnce(metaWarning, "v2_meta"); + } + let isCloudflareRuntime = ["cloudflare-pages", "cloudflare-workers"].includes( appConfig.serverBuildTarget ?? "" ); @@ -852,3 +856,8 @@ export const formMethodWarning = "prepare for the Remix v2 release. Lowercase `useNavigation().formMethod`" + "values are being normalized to uppercase in v2 to align with the `fetch()` " + "behavior. For more information, see https://remix.run/docs/hooks/use-navigation"; + +export const metaWarning = + "⚠️ DEPRECATED: Please enable the `future.v2_meta` flag to " + + "prepare for the Remix v2 release. For more information, see " + + "https://remix.run/docs/en/1.14.3/route/meta#md-metav2."; From f65c4a026456f6307cb4aeebb8e7eafb257d299b Mon Sep 17 00:00:00 2001 From: Matt Brophy Date: Wed, 22 Mar 2023 15:37:44 -0400 Subject: [PATCH 2/4] Add changeset --- .changeset/meta-deprecation-warning.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/meta-deprecation-warning.md diff --git a/.changeset/meta-deprecation-warning.md b/.changeset/meta-deprecation-warning.md new file mode 100644 index 00000000000..a38d531c509 --- /dev/null +++ b/.changeset/meta-deprecation-warning.md @@ -0,0 +1,5 @@ +--- +"@remix-run/dev": patch +--- + +Add deprecation warning for `future.v2_meta` From 61f3766f3c8fa96aadbe91f08893228b2df17228 Mon Sep 17 00:00:00 2001 From: Matt Brophy Date: Wed, 22 Mar 2023 16:44:50 -0400 Subject: [PATCH 3/4] Fix HMR integration test --- integration/hmr-test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/integration/hmr-test.ts b/integration/hmr-test.ts index 33b6894e22f..702db57ce08 100644 --- a/integration/hmr-test.ts +++ b/integration/hmr-test.ts @@ -18,6 +18,7 @@ let fixture = (options: { port: number; appServerPort: number }) => ({ v2_routeConvention: true, v2_errorBoundary: true, v2_normalizeFormMethod: true, + v2_meta: true, }, files: { "package.json": json({ From 2f51120eddb7ea9d58dfac29cc0d75ae5b8d9016 Mon Sep 17 00:00:00 2001 From: Matt Brophy Date: Wed, 22 Mar 2023 16:46:18 -0400 Subject: [PATCH 4/4] Remove hardcoded version from link --- packages/remix-dev/config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/remix-dev/config.ts b/packages/remix-dev/config.ts index c4746d1dc84..7b8366bfe8a 100644 --- a/packages/remix-dev/config.ts +++ b/packages/remix-dev/config.ts @@ -860,4 +860,4 @@ export const formMethodWarning = export const metaWarning = "⚠️ DEPRECATED: Please enable the `future.v2_meta` flag to " + "prepare for the Remix v2 release. For more information, see " + - "https://remix.run/docs/en/1.14.3/route/meta#md-metav2."; + "https://remix.run/docs/route/meta#md-metav2.";