Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable network selector #3883

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Feb 19, 2025

Description

  • Adds showNetworkSwitcher prop to allow disabling of network switching in the modal.

  • TODO: Handle case where user switches network in the wallet

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-2134

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Feb 19, 2025

Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: 8365ecd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-scaffold-ui Patch
@reown/appkit Patch
@reown/appkit-core Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 2:53pm
appkit-ethers5-bera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 2:53pm
appkit-laboratory 🛑 Canceled (Inspect) 💬 Add feedback Feb 19, 2025 2:53pm
next-wagmi-solana-bitcoin-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 2:53pm
9 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Feb 19, 2025 2:53pm
appkit-basic-ep-example ⬜️ Ignored (Inspect) Feb 19, 2025 2:53pm
appkit-basic-example ⬜️ Ignored (Inspect) Feb 19, 2025 2:53pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Feb 19, 2025 2:53pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Feb 19, 2025 2:53pm
appkit-vue-solana ⬜️ Ignored (Inspect) Feb 19, 2025 2:53pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Feb 19, 2025 2:53pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 2:53pm
vue-wagmi-example ⬜️ Ignored (Inspect) Feb 19, 2025 2:53pm

Copy link

linear bot commented Feb 19, 2025

Copy link
Contributor

Warnings
⚠️ File packages/appkit/src/client.ts contains a KEY or SECRET
⚠️ File packages/appkit/src/utils/TypesUtil.ts contains a KEY or SECRET
⚠️ File packages/core/src/controllers/OptionsController.ts contains a KEY or SECRET
⚠️ File packages/scaffold-ui/src/partials/w3m-header/index.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against 8365ecd

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.28% 23079 / 31927
🔵 Statements 72.28% 23079 / 31927
🔵 Functions 62.19% 1849 / 2973
🔵 Branches 81.03% 3992 / 4926
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/src/client.ts 59.97% 83.48% 76.68% 59.97% 182-183, 215-216, 236-237, 240-241, 256-259, 262-265, 285-286, 289-290, 306-340, 343-352, 367-368, 618-619, 622-625, 628-629, 632-633, 636-637, 640-641, 648-652, 717-727, 736-761, 768-771, 800-801, 815-816, 825-826, 829-830, 835-836, 860-861, 888-894, 920-931, 934-970, 973-978, 994-998, 1011-1022, 1025-1044, 1047-1053, 1056-1066, 1069-1081, 1084-1086, 1089-1091, 1094-1096, 1099-1101, 1104-1111, 1116-1174, 1182-1194, 1205-1219, 1222-1229, 1232-1243, 1246-1252, 1257, 1261, 1276, 1289-1290, 1298-1301, 1304-1307, 1310-1316, 1326-1327, 1359-1375, 1387-1390, 1394, 1410-1420, 1429-1430, 1436-1441, 1447-1465, 1471-1478, 1482-1497, 1515-1525, 1528-1607, 1610-1630, 1648, 1664-1665, 1671, 1673-1689, 1694, 1706, 1744-1751, 1753-1764, 1767-1775, 1813-1816, 1823-1829, 1836-1837, 1842-1843, 1882-1883, 1896-1897, 1902-1903, 1905-1906, 1911-1914, 1925-1926, 1965-1969, 1994-1995, 2019-2020, 2050-2051, 2055-2056, 2154-2160, 2193-2198, 2200-2210, 2212, 2214-2226, 2228-2242, 308-344
packages/appkit/src/utils/TypesUtil.ts 100% 100% 100% 100%
packages/core/src/controllers/OptionsController.ts 85.33% 97.61% 53.62% 85.33% 189, 198-199, 246, 250, 298-301, 305-308, 312-315, 319-322, 335
packages/scaffold-ui/src/partials/w3m-header/index.ts 91.56% 86.27% 78.94% 91.56% 85, 145-146, 154, 189, 200, 218, 241, 251, 259, 263-267, 270-275
Generated in workflow #9698 for commit 8365ecd by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant