Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: email wallet button & update email support #3925

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Feb 26, 2025

Description

Added email wallet button and update email support

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-2094,APKT-2349

Showcase (Optional)

wallet-button.mov

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: 58b73f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@reown/appkit-wallet-button Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-core Patch
@reown/appkit-ui Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 1:09pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 1:09pm
12 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Feb 26, 2025 1:09pm
appkit-basic-ep-example ⬜️ Ignored (Inspect) Feb 26, 2025 1:09pm
appkit-basic-example ⬜️ Ignored (Inspect) Feb 26, 2025 1:09pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Feb 26, 2025 1:09pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Feb 26, 2025 1:09pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Feb 26, 2025 1:09pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Feb 26, 2025 1:09pm
appkit-vue-solana ⬜️ Ignored (Inspect) Feb 26, 2025 1:09pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Feb 26, 2025 1:09pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 1:09pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Feb 26, 2025 1:09pm
vue-wagmi-example ⬜️ Ignored (Inspect) Feb 26, 2025 1:09pm

@@ -71,7 +71,8 @@ const SINGLE_ADAPTER_SOLANA_TESTS = [
'no-email.spec.ts',
'no-socials.spec.ts',
'debug-mode.spec.ts',
'wallet.spec.ts'
'wallet.spec.ts',
'wallet-button.spec'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added wallet button test for solana as well

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Warnings
⚠️ File apps/laboratory/src/components/AppKitWalletButtons.tsx contains a KEY or SECRET
⚠️ File apps/laboratory/tests/email-after-farcaster.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/email.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/multichain/multichain-ethers-solana-email-siwe.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/multichain/multichain-ethers-solana-email.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/multichain/multichain-ethers5-solana-email-siwe.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/multichain/multichain-ethers5-solana-email.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/multichain/multichain-wagmi-solana-email-siwe.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/multichain/multichain-wagmi-solana-email.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/shared/pages/ModalPage.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/siwe-email.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/siwe-sa.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/smart-account.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/wallet-button.spec.ts contains a KEY or SECRET
⚠️ File apps/laboratory/tests/wallet-features.spec.ts contains a KEY or SECRET
⚠️ File packages/core/src/controllers/RouterController.ts contains a KEY or SECRET
⚠️ File packages/scaffold-ui/src/modal/w3m-router/index.ts contains a KEY or SECRET
⚠️ File packages/scaffold-ui/src/partials/w3m-account-auth-button/index.ts contains a KEY or SECRET
⚠️ File packages/scaffold-ui/src/partials/w3m-header/index.ts contains a KEY or SECRET
⚠️ File packages/scaffold-ui/src/views/w3m-update-email-wallet-view/index.ts contains a KEY or SECRET
⚠️ File packages/wallet-button/exports/react.ts contains a KEY or SECRET
⚠️ File packages/wallet-button/src/client.ts contains a KEY or SECRET
⚠️ File packages/wallet-button/src/scaffold-ui/appkit-wallet-button/index.ts contains a KEY or SECRET
⚠️ Testing spec changed
⚠️ File packages/wallet-button/src/utils/ConnectorUtil.ts contains a KEY or SECRET
⚠️ File packages/wallet-button/src/utils/TypeUtil.ts contains a KEY or SECRET
⚠️ File packages/scaffold-ui/src/views/w3m-email-login-view/index.ts contains a KEY or SECRET
⚠️ File packages/scaffold-ui/src/views/w3m-email-login-view/index.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against 58b73f6

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 72.55% 23550 / 32459
🔵 Statements 72.55% 23550 / 32459
🔵 Functions 62.57% 1891 / 3022
🔵 Branches 81.47% 4148 / 5091
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/controllers/RouterController.ts 59.63% 96.15% 80% 59.63% 138-168, 217-228, 233-240
packages/scaffold-ui/exports/index.ts 100% 100% 100% 100%
packages/scaffold-ui/src/modal/w3m-router/index.ts 61.9% 21.53% 87.5% 61.9% 36-46, 60, 67, 71, 75, 77, 81, 83, 85, 87, 89, 91, 93, 95, 97, 99, 101, 103, 105, 107, 109, 111, 113, 115, 117, 119, 121, 123, 125, 127, 129, 131, 135, 137, 139, 141, 143, 145, 147, 149, 151, 153, 155, 157, 159, 161, 163, 165, 167, 169, 171, 173, 183-184
packages/scaffold-ui/src/partials/w3m-account-auth-button/index.ts 88.23% 77.77% 66.66% 88.23% 30, 36-37, 65, 78-79
packages/scaffold-ui/src/partials/w3m-header/index.ts 91.52% 86% 78.94% 91.52% 86, 146-147, 155, 190, 201, 219, 240, 250, 258, 262-266, 269-274
packages/scaffold-ui/src/views/w3m-email-login-view/index.ts 33.33% 100% 0% 33.33% 22-27, 31-46, 50-56
packages/scaffold-ui/src/views/w3m-update-email-secondary-otp-view/index.ts 93.54% 100% 0% 93.54% 10-11
packages/scaffold-ui/src/views/w3m-update-email-wallet-view/index.ts 11.68% 100% 0% 11.68% 14-27, 30-35, 39-53, 57-58, 61-94, 97-132
packages/ui/src/composites/wui-wallet-button/index.ts 100% 90.9% 100% 100%
packages/wallet-button/src/client.ts 85.71% 80% 80% 85.71% 31-32, 40-41, 51, 65-66
packages/wallet-button/src/scaffold-ui/appkit-wallet-button/index.ts 81.39% 75.6% 75% 81.39% 53, 61-62, 67-68, 74-75, 85, 109, 176-192
packages/wallet-button/src/utils/ConnectorUtil.ts 14.4% 80% 20% 14.4% 39-40, 65-79, 81-236, 238-260, 262-305
Generated in workflow #9835 for commit 58b73f6 by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant