Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .rrd files to git lfs to test backwards compatibility #9110

Open
3 tasks
emilk opened this issue Feb 22, 2025 · 0 comments
Open
3 tasks

Add .rrd files to git lfs to test backwards compatibility #9110

emilk opened this issue Feb 22, 2025 · 0 comments
Assignees
Labels

Comments

@emilk
Copy link
Member

emilk commented Feb 22, 2025

We want to have automated tests to make sure we have backwards compatible chunk loaders.

Ideally we should add .rrd files to git lfs for all previous versions of all components and archetypes.

What to test?

  • They load without error/warning
  • Passes rerun rrd verify
  • Produce the same rerun print output?
    • Maybe just the column headers (names, meta-data)?
    • That's a useful sanity check when we update the .rrd:s in the test set, that the new ones covers approximately the same things
  • Produce the same visuals? Difficult to get right

What .rrd files?

  • Snippets?
  • Examples?
  • One .rrd file containing all known components/archetypes/datatypes?

When and how do we add more .rrd files to the test set?

What if something does break?

We do not yet promise full backwards compatibility, but any CI failure regarding this should be a red flag, and we should only accept it (and upload a new .rrd file) if we are really ok with this breaking change.

@emilk emilk added the 🔩 data model Sorbet label Feb 22, 2025
@emilk emilk changed the title Add data files to git lfs to test backwards compatibility Add .rrd files to git lfs to test backwards compatibility Feb 25, 2025
@emilk emilk self-assigned this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant