Remove temp:// and some old MessageProxy variants
#9129
Conversation
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
jprochazk
added
the
exclude from changelog
| let url = format!("http://{server_addr}") | ||
| .parse() | ||
| .expect("should always be valid"); | ||
| let url = format!("http://{server_addr}/proxy"); |
| @@ -210,6 +210,12 @@ impl WebViewerConfig { | |||
| }; | |||
|
|
|||
| if let Some(source_url) = source_url { | |||
| // TODO(jan): remove after we change to `rerun-http` | |||
There was a problem hiding this comment.
I'm a bit confused by this TODO -- what still needs to change?
There was a problem hiding this comment.
+ in a query param is treated as whitespace, meaning that to actually connect to a Rerun server from the web viewer, you need to percent-encode the URL first (or at least the + character, you can see it all over the place here). We want to change it (in a separate PR) to rerun-http/rerun-https instead of rerun+http/rerun+https, because the - character does not have special meaning in any part of the URL.
|
Looks like we need a missing rerun/crates/top/re_sdk/src/web_viewer.rs Line 77 in 8e61d06 |
|
tested with: opens browser and streams data correctly |
Related
grpc://client for both Storage Node and re_grpc_server #8761What
Removes the temporary
temp://URI scheme and streamlines handling of URIs.