Low-hanging optimizations of the time panel #8819
Conversation
abey79
added
🚀 performance
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
but the snapshot tests catch something. So maybe that changes appearance in some cases? edit: this should be unrelated? those tests are about the blueprint panel, not the timepanel |
I'm changing a function that is also called in the blueprint tree, and apparently I broke it. Will look into it. |
| @@ -185,8 +185,7 @@ pub fn instance_path_icon( | |||
| if db | |||
| .storage_engine() | |||
| .store() | |||
| .all_components_on_timeline(timeline, &instance_path.entity_path) | |||
| .is_some() | |||
| .entity_has_data_on_timeline(timeline, &instance_path.entity_path) | |||
There was a problem hiding this comment.
This behaves slightly differently for reasons I don't really comprehend, at least in some tests.
There was a problem hiding this comment.
According to Clement, one is affected by GC but not the other, which doesn't explain why it break a test where no GC is supposed to take place.
|
Drafting this for now—I'll revisit it after my other PRs have landed. |
|
Scrap that. I'll integrate all of this in my refactor. |
|
Will be moved elsewhere |
Related
What
Two small optimisations which, together, account for 2ms in a worse case scenario.
Benchmark: air traffic data, no views, uncollapsed time panel
Result: