New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robust summary aggregation is very slow for SCP data #123

Open

cvanderaa opened this issue Jan 28, 2021 · 1 comment

Assignees

Labels

Collaborator

cvanderaa commented Jan 28, 2021 •

edited

Loading

For large data such single-cell proteomics data, the robust summary aggregation is very slow. You can test this with this example:

library(scpdata)
library(scp)
aggregateFeatures(specht2019v3(), 
                  i = "peptides",
                  name = "proteins_rs",
                  fcol = "protein", 
                  fun = MsCoreUtils::robustSummary)

I stopped the run after 1 hour.

lgatto added the enhancement label

Member

lgatto commented Jan 28, 2021

It would be useful to profile the code and identify what chunks take time and why they do (cpu time, memory management, ...).

cvanderaa self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment