Added Policy State Getters

[Dhruv-Mishra]

Added Policy State Getters for the policies defined here

Related to issue: #109

[Dhruv-Mishra]

Added dummy abi at the moment, if all else looks correct, will build and update with the actual ones as per the contracts in this branch

[Dhruv-Mishra]

@kopy-kat, is there a contract already deployed on-chain for testing purposes? Or should I deploy one to write and validate tests for all the policies, or is it not necessary to add tests for these getters?

[kopy-kat]

good question, to be honest if you can write tests for the getters and just check against empty values (to make sure it doesnt revert) that could be enough for now - but if you want to populate some data and then test against this then that would obvs also work

[Dhruv-Mishra]

good question, to be honest if you can write tests for the getters and just check against empty values (to make sure it doesnt revert) that could be enough for now - but if you want to populate some data and then test against this then that would obvs also work

I have added some tests to check against empty values. I want to write more thorough tests but I think it would be better if I do it after the contracts are deployed.

I was unable to get the ABIs for the updated contract using forge build, or by compiling with solc. Therefore, for all policies except uni action policy, I am using the ABIs of the old contracts at the moment which have the same structure for the getter functions. I can either leave the ABIs out of this PR or update the ABIs for the updated contracts if I can get them.

I have also updated the PR to reflect the most recent update to the contracts.

[kopy-kat]

the contracts are deployed on sepolia with the addresses here (for those that changed) or the addresses already in the sdk: #109

when you run forge build you should get the abis in the out folder - make sure to use the moar-policies branch and let me know if that still doesnt work for you

[Dhruv-Mishra]

the contracts are deployed on sepolia with the addresses here (for those that changed) or the addresses already in the sdk: #109

when you run forge build you should get the abis in the out folder - make sure to use the moar-policies branch and let me know if that still doesnt work for you

It worked now.

In case anyone else encounters this:
The issue was in the test/mock/erc7679/UserOpBuilder.sol file. The import statement:

import "forge-std/Console2.sol";

was failing because the Node modules had the filename as console2.sol. Updating the import to:

import "forge-std/console2.sol";

fixed the issue.

I still get a lot of warnings when compiling the contracts, is that expected?

[kopy-kat]

yeah warnings are fine

[Dhruv-Mishra]

@kopy-kat Raised #122 with the new changes, closing this as the branch is divergent with main now and would require resolving all merge conflicts again.