Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: to ConfigId helper #127

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: to ConfigId helper #127

wants to merge 11 commits into from

Conversation

Dhruv-Mishra
Copy link
Contributor

As discussed in #109

@Dhruv-Mishra Dhruv-Mishra mentioned this pull request Feb 2, 2025
Open
3 tasks
@Dhruv-Mishra Dhruv-Mishra changed the title Feat/to config id helper To ConfigId Helper Feb 2, 2025
@Dhruv-Mishra Dhruv-Mishra changed the title To ConfigId Helper feat: to ConfigId helper Feb 2, 2025
@Dhruv-Mishra
Copy link
Contributor Author

@kopy-kat requesting review on this

@Dhruv-Mishra
Copy link
Contributor Author

@kopy-kat added functions as per your review

If this looks good to you, can you squash the commits before merging, I created multiple commits to fix unwanted file changes due to EOL spaces 😅

kopy-kat
kopy-kat approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@kopy-kat kopy-kat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kopy-kat kopy-kat kopy-kat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dhruv-Mishra @kopy-kat