Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Windows static libraries through GitHub actions #195

Open
khevessy opened this issue Aug 17, 2023 · 3 comments
Open

Building Windows static libraries through GitHub actions #195

khevessy opened this issue Aug 17, 2023 · 3 comments

Comments

@khevessy
Copy link
Contributor

As @riebl said here, it would be great to have Windows/MSVC as another target included in the GitHub actions executed for every commit. I am now not able to do this, but I am making this issue as a reminder to implement it or maybe someone else will do it.

@riebl
Copy link
Owner

riebl commented Feb 8, 2025

Is this still of interest to you @khevessy? If yes, does it need to be built with MSVC or would MinGW also be an option?

@khevessy
Copy link
Contributor Author

khevessy commented Feb 10, 2025

@riebl Our use case is building Vanetza to dlls using MSVC with a C++/CLI wrapper, that can be used by a .NET application. I have a branch that contains the changes needed to do that (the wrapper is not there). The changes are mainly about symbol exports. There is also a Python script that does the changes needed for the Visual Studio project. I am not sure that you want this in the upstream repository, though.

Edit: noticed that I did not answer your question, well I am not sure, I think that for our purposes MinGW could not be used.

@riebl
Copy link
Owner

riebl commented Feb 10, 2025

Thanks for pointing me to your Windows-enabled branch! As a rule of thumb, I am happy to have anything in the upstream repository that is potentially useful for more than one party (and related to Vanetza, of course).
I will experiment a little bit with the Windows build as soon as possible, so I get a feeling on how to add it to our CI as well. I don't want to brick the Windows build accidentally at the next commit ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants