Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize writer in another library #40

Open
leodido opened this issue Jan 20, 2015 · 1 comment
Open

Externalize writer in another library #40

leodido opened this issue Jan 20, 2015 · 1 comment
Assignees
Milestone

Comments

@leodido
Copy link
Contributor

leodido commented Jan 20, 2015

Externalize writer architecture and classes.

Then require this library and extend class to add

if (!isset($doc['id'])) {
    throw new NotValidDocumentException('Document array must have an element with "id" key');
}

where it is needed.

@leodido leodido self-assigned this Jan 20, 2015
@leodido leodido added this to the 1.0.0 milestone Jan 20, 2015
@leogr
Copy link
Contributor

leogr commented May 9, 2015

I don't think that externalizing the writer is an improvement.
The writer is very specific and it could be used as standalone component already (just using zf2-sphinxsearch-tool as depedency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants