Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate from jsr.io to npm #2005

Closed
wants to merge 1 commit into from
Closed

chore: migrate from jsr.io to npm #2005

wants to merge 1 commit into from

Conversation

NathanFlurry
Copy link
Member

Changes

This was referenced Feb 8, 2025
Closed
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Feb 8, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry mentioned this pull request Feb 8, 2025
Closed
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Feb 8, 2025 •
edited
Loading

Merge activity

  • Feb 7, 8:03 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 7, 8:04 PM EST: CI is running for this PR on a draft PR: #2007
  • Feb 7, 8:05 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #2007.

greptile-apps[bot]
greptile-apps bot reviewed Feb 8, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR migrates all SDK documentation links from jsr.io to npm.js, consolidating package distribution through npm's registry.

  • Updated Actor SDK link to https://www.npmjs.com/package/@rivet-gg/actor in sdks/actor/client/README.md and sitemap
  • Removed slow types section from sdks/actor/README.md as it's no longer relevant for npm distribution
  • Consolidated JavaScript/TypeScript SDK entries into a single TypeScript entry in site/src/sitemap/mod.ts
  • Updated Actor Client SDK reference in sdks/actor/runtime/README.md to point to npm package

5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

site/src/content/docs/index.mdx
Comment on lines +36 to +37
<Card title='JavaScript' href='https://www.npmjs.com/package/@rivet-gg/actor-client' target='_blank' />
<Card title='TypeScript' href='https://www.npmjs.com/package/@rivet-gg/actor-client' target='_blank' />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Both JavaScript and TypeScript SDKs point to the same package. Consider if these should be separate packages or if one card should be removed

graphite-app bot pushed a commit that referenced this pull request Feb 8, 2025
@NathanFlurry
chore: migrate from jsr.io to npm (#2005)
0a6d677 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Feb 8, 2025
@graphite-app graphite-app bot deleted the chore_migrate_from_jsr.io_to_npm branch February 8, 2025 01:05
@github-actions github-actions bot mentioned this pull request Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NathanFlurry