Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the code for non-constant-time storr operations #566

Closed
wlandau opened this issue Oct 31, 2018 · 1 comment
Closed

Review the code for non-constant-time storr operations #566

wlandau opened this issue Oct 31, 2018 · 1 comment
Assignees
@wlandau
Labels
topic: performance

Comments

@wlandau
Copy link
Member

wlandau commented Oct 31, 2018

such as $list(). Functions with unbounded complexity should not be called in make(). Ref: #563 (comment)
@wlandau wlandau self-assigned this Oct 31, 2018
@wlandau
Copy link
Member Author

wlandau commented Oct 31, 2018 •
edited
Loading

From looking at the storr_rds() API, the only method we need to worry about is $list(). I searched drake's code base, and it is used sparingly.

More generally speaking, I would like to concentrate on downsizing and accelerating drake. #561, #562, and #464 cover most of the initial downsizing. I also plan to put more effort into profiling.

@wlandau wlandau closed this as completed Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlandau wlandau

Labels
topic: performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wlandau