-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulated encoders #968
Comments
Let's use object composition instead of inheritance. |
Idea:
|
Nope, let's just make encoding and decoding part of the decorated storr. |
Yup, extra functions in the decorated |
Just need to verify that #1011 did not reduce performance. |
Just ran a couple versions of the overhead example. Flame graphs look the same as before with no obvious bottlenecks. |
Prework
drake
's code of conduct.Description
We have 4 hash tables to encode and decode paths and namespaced functions.
ht_encode_path
ht_decode_path
ht_encode_namespaced
ht_decode_namespaced
Let's add some OOP. We could create a new "encoder" class that inherits from the hash table class. Depends on #967.
The text was updated successfully, but these errors were encountered: